fix: bootstrap reload in offline mode. #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After adding support for client and frontend tokens, we did not extend the reloader to check client and frontend token Vecs, this PR extends tokens with FE and Client tokens, to ensure that we refresh the data for all our tokens. In addition we make /internal-backstage/tokens useful for offline mode as well, to at least be able to see which tokens you added to Edge. Fixes: #594
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
nunogois
reviewed
Dec 6, 2024
| srv.call(req).await?.map_into_left_body() | ||
| } else { | ||
| req.into_response(HttpResponse::Forbidden().finish()) | ||
| .map_into_right_body() | ||
| } | ||
| } | ||
| Some(TokenType::Client) => { | ||
| trace!("Got Client token validated {:?}", known_token); |
There was a problem hiding this comment.
Any reason why we're getting rid of these now?
There was a problem hiding this comment.
We've verified that it triggers, and we have the /internal-backstage/tokens endpoint to see which tokens we know about, so cleaned it up.
|
@chriswk Thanks for fixing both things. The question is, when is a new release with the fix available? Do you have an information for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding support for client and frontend tokens, we did not extend the reloader to check client and frontend token Vecs, this PR extends tokens with FE and Client tokens, to ensure that we refresh the data for all our tokens.
In addition we make /internal-backstage/tokens useful for offline mode as well, to at least be able to see which tokens you added to Edge.
In addition, since offline mode did not set up a token validator, I extended the auth middleware to check if our offline token has a token type set and if they do, limit their access to what they were intended for (client for /api/client, frontend for /api/frontend | /api/proxy)
Fixes: #594