chore: make clippy warnings into failures #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files.github/workflows/clippy.yaml
|
chriswk
reviewed
Jul 19, 2024
sighphyre
force-pushed
the
chore/make-clippy-fail-the-build
branch
from
efffa20 to
8f53ee2
Compare
sighphyre
commented
Jul 19, 2024
server/src/types.rs
Outdated
| @@ -645,14 +645,14 @@ mod tests { | |||
| fn context_conversion_properties_level_properties_take_precedence_over_top_level() { | |||
| let context = Context { | |||
| properties: Some(HashMap::from([( | |||
| "duplicated property".into(), | |||
| "probably_a_duplicated property".into(), | |||
There was a problem hiding this comment.
Turns out I had to do this to dodge the cache. It's just a data change in a test to kick the build
alvinometric
changed the title
… if we just block a merge on any found issue
…et of method parameters
sighphyre
force-pushed
the
chore/make-clippy-fail-the-build
branch
from
afffbdf to
e94f66a
Compare
sighphyre
force-pushed
the
chore/make-clippy-fail-the-build
branch
from
873e846 to
d29241f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.