Feat/use etag from upstream #390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| fn new_transform(&self, service: S) -> Self::Future { | ||
| ok(EdgeETagMiddleware { | ||
| service: service, |
Check warning
Code scanning / clippy
redundant field names in struct initialization Warning
chriswk
force-pushed
the
feat/useEtagFromUpstream
branch
2 times, most recently
from
2137ff8
to
7fefc52
Compare
sighphyre
reviewed
Jan 17, 2024
| use super::*; | ||
|
|
||
| #[test] | ||
| fn building_an_initial_state_from_backup_also_adds_etags_for_features() { |
sighphyre
reviewed
Jan 17, 2024
server/src/middleware/etag.rs
Outdated
| client_token: &Option<EdgeToken>, | ||
| if_none_match: &Option<IfNoneMatch>, | ||
| ) -> bool { | ||
| match (if_none_match, client_token) { |
There was a problem hiding this comment.
The match one looks odd to me here. You can do a tuple destructuring if let Some here:
fn we_know_this_etag_from_upstream(
etag_cache: Arc<DashMap<EdgeToken, EntityTag>>,
client_token: &Option<EdgeToken>,
if_none_match: &Option<IfNoneMatch>,
) -> bool {
if let (Some(if_none), Some(token)) = (if_none_match, client_token) {
etag_cache.get(token).map_or(false, |etag| {
if_none == &IfNoneMatch::Any || if_none.to_string() == etag.to_string()
})
} else {
false
}
}
Entirely optional
sighphyre
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our client features endpoint to rely on etag we get from upstream, avoiding doing the service call and just returning 304 if we match.