Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strategy variants #205

Merged
merged 9 commits into from
Jul 26, 2023
Merged

feat: strategy variants #205

merged 9 commits into from
Jul 26, 2023

Conversation

andreas-unleash
Copy link
Contributor

Implements strategy variants based on the client-specifications v4.3.0

About the changes

Closes #

Important files

Discussion points

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 20, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@andreas-unleash andreas-unleash marked this pull request as ready for review July 24, 2023 12:09
src/main/java/io/getunleash/DefaultUnleash.java Outdated Show resolved Hide resolved
src/main/java/io/getunleash/DefaultUnleash.java Outdated Show resolved Hide resolved
src/main/java/io/getunleash/Unleash.java Outdated Show resolved Hide resolved
src/main/java/io/getunleash/variant/VariantDefinition.java Outdated Show resolved Hide resolved
src/main/java/io/getunleash/variant/VariantUtil.java Outdated Show resolved Hide resolved
src/main/java/io/getunleash/variant/VariantUtil.java Outdated Show resolved Hide resolved
src/main/java/io/getunleash/variant/VariantUtil.java Outdated Show resolved Hide resolved
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 25, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/Unleash/unleash-client-java/205.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/Unleash/unleash-client-java/205.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@kwasniew kwasniew self-requested a review July 25, 2023 08:17
@andreas-unleash andreas-unleash merged commit 78a0d33 into main Jul 26, 2023
4 checks passed
@andreas-unleash andreas-unleash deleted the feat/strategy_variants branch July 26, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants