Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added volume and volume mounts #172

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Oct 22, 2024

fixes: #171

@chriswk chriswk self-assigned this Oct 22, 2024
@chriswk chriswk force-pushed the task/addVolumeAndVolumeMounts branch from f9e9a0e to 30d129a Compare October 22, 2024 08:20
args:
- "offline"
env:
- name: TOKENS
value: {{ .Values.proxy.apiToken }}
- name: BOOTSTRAP_FILE
value: /data/config/features.json
image: "unleashorg/unleash-edge:v{{ .Values.edge.version }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this broken? It looks broken

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was broken

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chriswk chriswk merged commit 07d7113 into main Oct 23, 2024
12 checks passed
@chriswk chriswk deleted the task/addVolumeAndVolumeMounts branch October 23, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Import extra volumes and extra volumeMounts to pod
2 participants