Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include name helper for container name in all three charts #154

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Jul 4, 2024

This allows you to use nameOverride if you don't want to use the Chart.name as your container name.

fixes: #153

@chriswk chriswk requested a review from gardleopard July 4, 2024 11:24
@chriswk chriswk self-assigned this Jul 4, 2024
@chriswk chriswk linked an issue Jul 4, 2024 that may be closed by this pull request
@chriswk chriswk mentioned this pull request Jul 4, 2024
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a sane thing to do be doing. Just gotta get the build happy

@chriswk chriswk merged commit b2c6594 into main Jul 9, 2024
5 of 8 checks passed
@chriswk chriswk deleted the 153-edge-container-name-issue branch July 9, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge Container name issue
2 participants