Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make target port customisable for unleash helm chart #141

Merged
merged 4 commits into from
May 16, 2024
Merged

make target port customisable for unleash helm chart #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
310828b
make target port customisable
martinrw Apr 29, 2024
09a53b3
make target port customisable
martinrw Apr 29, 2024
8d0bf6a
make target port customisable
martinrw Apr 29, 2024
d38a5cc
Merge branch 'main' into main
chriswk May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/unleash/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ icon: https://docs.getunleash.io/img/logo.svg

type: application

version: 4.2.0
version: 4.2.1

appVersion: "5.12.2"

Expand Down
2 changes: 1 addition & 1 deletion charts/unleash/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
type: {{ .Values.service.type }}
ports:
- port: {{ .Values.service.port }}
targetPort: http
targetPort: {{ .Values.service.targetPort | default .Values.service.port }}
{{- if and (or (eq .Values.service.type "NodePort") (eq .Values.service.type "LoadBalancer")) (not (empty .Values.service.nodePort)) }}
nodePort: {{ .Values.service.nodePort }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions charts/unleash/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ service:
# Supported types: ClusterIP, NodePort, LoadBalancer
type: ClusterIP
port: 4242
# target port will be set to port if not set
targetPort: ""
# nodePort is optional and only used when service.type is NodePort or LoadBalancer
nodePort: ""
annotations: {}
Expand Down
Loading