Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add optional startup probe and simplify liveness and readiness probes #129

Conversation

brtkwr
Copy link
Contributor

@brtkwr brtkwr commented Jan 4, 2024

About the changes

Important files

Discussion points

This PR adds a mechanism for users to define a startup probe where failure to hot load edge containers with flags blocks startup.

If we like this approach, we copy the simplification to other charts.

@brtkwr brtkwr force-pushed the brtknr/t-14993-use-unleash-edge-to-scale-unleash-deployment branch 2 times, most recently from 60083aa to eafb5ee Compare January 4, 2024 09:07
@brtkwr brtkwr force-pushed the brtknr/t-14993-use-unleash-edge-to-scale-unleash-deployment branch from eafb5ee to 5ebcf38 Compare January 4, 2024 11:58
@brtkwr brtkwr changed the title feat: Add startup probe and simplify liveness and readiness probes feat: Add optional startup probe and simplify liveness and readiness probes Jan 4, 2024
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brtknr, this looks great, thank you so much for the contribution

@sighphyre sighphyre merged commit 6d9333f into Unleash:main Jan 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants