feat: Add startup probe and simplify liveness and readiness probes

Unleash · Jan 4, 2024 · fa0e89e · fa0e89e
1 parent 4f5c841
commit fa0e89e
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 29 deletions.
diff --git a/charts/unleash-edge/Chart.yaml b/charts/unleash-edge/Chart.yaml
@@ -4,7 +4,7 @@ name: unleash-edge
 description: A Helm chart for deploying Unleash Edge to kubernetes
 icon: https://docs.getunleash.io/img/logo.svg
 type: application
-version: 2.2.3
+version: 2.3.0
 
 appVersion: "v16.0.6"
 maintainers:

diff --git a/charts/unleash-edge/templates/deployment.yaml b/charts/unleash-edge/templates/deployment.yaml
@@ -59,23 +59,17 @@ spec:
             - name: http
               containerPort: 3063
               protocol: TCP
-          {{- if .Values.livenessProbe.enabled | default true }}
+          {{- with .Values.startupProbe }}
+          startupProbe:
+            {{- toYaml . | nindent 12 }}
+          {{- end }}
+          {{- with .Values.livenessProbe }}
           livenessProbe:
-            httpGet:
-              path: {{ .Values.livenessProbe.path | default "/internal-backstage/health" }}
-              port: http
-            initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds | default 30 }}
-            timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds | default 10 }}
+            {{- toYaml . | nindent 12 }}
           {{- end }}
-          {{- if .Values.readinessProbe.enabled | default true}}
+          {{- with .Values.readinessProbe }}
           readinessProbe:
-            httpGet:
-              path: {{ .Values.readinessProbe.path | default "/internal-backstage/health" }}
-              port: http
-            initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds | default 30 }}
-            timeoutSeconds: {{.Values.readinessProbe.timeoutSeconds | default 10 }}
-            successThreshold: {{.Values.readinessProbe.successThreshold | default 5 }}
-            periodSeconds: {{.Values.readinessProbe.periodSeconds | default 10 }}
+            {{- toYaml . | nindent 12 }}
           {{- end }}
           {{ with .Values.volumeMounts }}
           volumeMounts:
@@ -108,4 +102,4 @@ spec:
       {{- range . }}
       - {{ toYaml . | nindent 8 | trim }}
       {{- end }}
-      {{- end }}
+      {{- end }}
diff --git a/charts/unleash-edge/values.yaml b/charts/unleash-edge/values.yaml
@@ -73,19 +73,41 @@ ingress:
   #    hosts:
   #
 
-livenessProbe: {}
-#   enabled: true
-#   path: /internal-backstage/health
-#   initialDelaySeconds: 30
-#   timeoutSeconds: 10
-
-readinessProbe: {}
-# enabled: true
-#   path: /internal-backstage/health
-#   initialDelaySeconds: 30
-#   timeoutSeconds: 10
-#   periodSeconds: 10
-#   successThreshold: 5
+startupProbe:
+  exec:
+    command: ["/unleash-edge", "ready"]
+  # httpGet:
+  #   path: /internal-backstage/health
+  #   port: http
+  initialDelaySeconds: 10
+  timeoutSeconds: 10
+  periodSeconds: 10
+  successThreshold: 1
+  failureThreshold: 10
+
+livenessProbe:
+  exec:
+    command: ["/unleash-edge", "health"]
+  # httpGet:
+  #   path: /internal-backstage/health
+  #   port: http
+  initialDelaySeconds: 10
+  timeoutSeconds: 10
+  periodSeconds: 10
+  successThreshold: 1
+  failureThreshold: 5
+
+readinessProbe:
+  exec:
+    command: ["/unleash-edge", "health"]
+  # httpGet:
+  #   path: /internal-backstage/health
+  #   port: http
+  initialDelaySeconds: 10
+  timeoutSeconds: 10
+  periodSeconds: 10
+  successThreshold: 1
+  failureThreshold: 1
 
 autoscaling:
   enabled: false