Skip to content

Commit

Permalink
fix: set DATABASE_NAME instead of DATABASE. (#137)
Browse files Browse the repository at this point in the history
- Unleash looks for DATABASE_NAME, it does not look for DATABASE, so
  this has actually not been working earlier

fixes: #136
  • Loading branch information
chriswk authored Mar 13, 2024
1 parent af75e9d commit c9566e7
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 12 deletions.
16 changes: 8 additions & 8 deletions charts/unleash/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
apiVersion: v2
appVersion: "5.9.6"
dependencies:
- name: postgresql
repository: https://charts.bitnami.com/bitnami
version: 12.1.6
condition: postgresql.enabled
- name: postgresql
repository: https://charts.bitnami.com/bitnami
version: 12.1.6
condition: postgresql.enabled
description: Unleash is a open source feature flag & toggle system, that gives you a great overview over all feature toggles across all your applications and services.
maintainers:
- name: evanstucker-hates-2fa
- name: ivarconr
email: [email protected]
- name: evanstucker-hates-2fa
- name: ivarconr
email: [email protected]
name: unleash
sources:
- https://github.com/Unleash/unleash
- https://github.com/Unleash/helm-charts
type: application
version: 4.0.1
version: 4.0.2
2 changes: 1 addition & 1 deletion charts/unleash/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
name: {{ if .Values.dbConfig.useExistingSecret.name }}{{ .Values.dbConfig.useExistingSecret.name }}{{ else }}{{ .Values.postgresql.fullnameOverride }}{{ end }}
key: {{ if .Values.dbConfig.useExistingSecret.key }}{{ .Values.dbConfig.useExistingSecret.key }}{{ else }}password{{ end }}
{{- end }}
- name: DATABASE
- name: DATABASE_NAME
value: "{{ .Values.dbConfig.database }}"
- name: DATABASE_HOST
value: "{{ if .Values.postgresql.enabled }}{{ .Values.postgresql.fullnameOverride }}{{ else }}{{ .Values.dbConfig.host }}{{ end }}"
Expand Down
10 changes: 7 additions & 3 deletions charts/unleash/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ containerPort: 4242

dbConfig:
# if postgres dependency chart is used, this needs to be the same value as postgresql.auth.database
# Will be used to set DATABASE_NAME as an environment variable.
database: unleash
# Defaults to 'public'
schema: ""
Expand All @@ -133,7 +134,8 @@ env: []
# value: https://unleash.example.com/api/auth/callback

# adds environmentvars for existing secrets to the container via tpl function
existingSecrets: []
existingSecrets:
[]
# - name: GOOGLE_CLIENT_SECRET
# valueFrom:
# secretKeyRef:
Expand All @@ -144,7 +146,8 @@ fullnameOverride: ""

image:
repository: unleashorg/unleash-server
tag: # Obtained from .Chart.AppVersion, up to date tags available at https://hub.docker.com/r/unleashorg/unleash-server/tags
# Obtained from .Chart.AppVersion, up to date tags available at https://hub.docker.com/r/unleashorg/unleash-server/tags
tag:
pullPolicy: Always

imagePullSecrets: []
Expand All @@ -161,7 +164,8 @@ serviceAccount:
ingress:
enabled: false
className: ""
annotations: {}
annotations:
{}
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
hosts:
Expand Down

0 comments on commit c9566e7

Please sign in to comment.