fix: make existing secrets an array of secret refs (#134)

Unleash · Feb 23, 2024 · 9b430c2 · 9b430c2
1 parent 81ee2e4
commit 9b430c2
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/charts/unleash/Chart.yaml b/charts/unleash/Chart.yaml
@@ -15,4 +15,4 @@ sources:
   - https://github.com/Unleash/unleash
   - https://github.com/Unleash/helm-charts
 type: application
-version: 3.1.4
+version: 4.0.0
diff --git a/charts/unleash/examples/existingSecrets.yaml b/charts/unleash/examples/existingSecrets.yaml
@@ -0,0 +1,6 @@
+existingSecrets:
+  - name: GOOGLE_CLIENT_SECRET
+    valueFrom:
+      secretKeyRef:
+        name: secretname
+        key: secretkey
diff --git a/charts/unleash/templates/deployment.yaml b/charts/unleash/templates/deployment.yaml
@@ -68,8 +68,14 @@ spec:
                   key: {{ $key }}
             {{- end }}
             {{- end }}
-            {{- with .Values.existingSecrets }}
-              {{- tpl . $ | nindent 12 }}
+            {{ if .Values.existingSecrets}}
+            {{- range .Values.existingSecrets }}
+            - name: {{ .name }}
+              valueFrom:
+                secretKeyRef:
+                  name: {{ .valueFrom.secretKeyRef.name }}
+                  key: {{ .valueFrom.secretKeyRef.key }}
+            {{- end }}
             {{- end }}
           image: "{{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}

diff --git a/charts/unleash/values.yaml b/charts/unleash/values.yaml
@@ -133,8 +133,7 @@ env: []
 #    value: https://unleash.example.com/api/auth/callback
 
 # adds environmentvars for existing secrets to the container via tpl function
-existingSecrets:
-  ""
+existingSecrets: []
   # - name: GOOGLE_CLIENT_SECRET
   #   valueFrom:
   #     secretKeyRef: