bug: don't set default "requests" in Unleash Edge chart values.yaml (#…

…122) * bug: don't set default "requests" in Unleash Edge chart values.yaml setting up default "requests" makes it impossible to omit certain portions of "requests" in local values.yaml file, e.g. not setting resources.limits.cpu is impossible * updated unleash-edge chart version to reflect default requests removal --------- Co-authored-by: m-barczyk <[email protected]>
Unleash · Dec 21, 2023 · 4fa860d · 4fa860d
1 parent 4cd3a4a
commit 4fa860d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/charts/unleash-edge/Chart.yaml b/charts/unleash-edge/Chart.yaml
@@ -4,7 +4,7 @@ name: unleash-edge
 description: A Helm chart for deploying Unleash Edge to kubernetes
 icon: https://docs.getunleash.io/img/logo.svg
 type: application
-version: 2.2.2
+version: 2.2.3
 
 appVersion: "v16.0.6"
 maintainers:

diff --git a/charts/unleash-edge/values.yaml b/charts/unleash-edge/values.yaml
@@ -45,12 +45,17 @@ service:
   nodePort: ""
 
 resources:
-  requests:
-    cpu: 100m
-    memory: 64Mi
-  limits:
-    cpu: 200m
-    memory: 64Mi
+  {}
+  # We usually recommend not to specify default resources and to leave this as a conscious
+  # choice for the user. This also increases chances charts run on environments with little
+  # resources, such as Minikube. If you do want to specify resources, uncomment the following
+  # lines, adjust them as necessary, and remove the curly braces after 'resources:'.
+  # requests:
+  #   cpu: 100m
+  #   memory: 64Mi
+  # limits:
+  #   cpu: 200m
+  #   memory: 64Mi
 
 ingress:
   enabled: false