Skip to content

Commit

Permalink
feat: generic extra manifests for unleash chart (#124)
Browse files Browse the repository at this point in the history
* feat: generic extra manifests for unleash chart

This allows including resources like credentials for the database
connection or the secret env vars for unleash (e.g. shared secret,
google client secret, ...) from a 3rd-party secrets provider and then
referencing those secrets in the "existing secrets"
  • Loading branch information
langesven authored Dec 27, 2023
1 parent e569828 commit 3bbf47e
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/unleash/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ sources:
- https://github.com/Unleash/unleash
- https://github.com/Unleash/helm-charts
type: application
version: 3.1.0
version: 3.1.1
8 changes: 8 additions & 0 deletions charts/unleash/templates/extra-manifests.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{{ range .Values.extraObjects }}
---
{{- if typeIs "string" . }}
{{- tpl . $ }}
{{- else }}
{{- tpl (toYaml .) $ }}
{{- end }}
{{ end }}
11 changes: 11 additions & 0 deletions charts/unleash/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,17 @@ autoscaling:
targetCPUUtilizationPercentage: 70
targetMemoryUtilizationPercentage: 70

extraObjects: []
# - apiVersion: mumoshu.github.io/v1alpha1
# kind: AWSSecret
# metadata:
# name: unleash-secret
# spec:
# stringDataFrom:
# secretsManagerSecretRef:
# secretId: unleash-secret-production
# versionId: 00000000-1111-2222-3333-444444444444

# CloudSQL in GKE
cloudsql:
# If you enable cloudsql, ensure that serviceAccount.annotations is populated with associated GKE workload identity:
Expand Down

0 comments on commit 3bbf47e

Please sign in to comment.