Fix component lifecycle #1098
Merged
Fix component lifecycle #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I don't understand why I closed this one month ago. We should merge this and create a separate issue for creating lifecycle tests. |
VinDp
approved these changes
Oct 21, 2024
|
@Mergifyio backport humble @Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2024
* Correctly reset async_thread_shutdown when starting the async thread * Do not use a global log handler object --------- (cherry picked from commit 141a17a)
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2024
* Correctly reset async_thread_shutdown when starting the async thread * Do not use a global log handler object --------- (cherry picked from commit 141a17a)
fmauch
pushed a commit
that referenced
this pull request
Oct 26, 2024
* Correctly reset async_thread_shutdown when starting the async thread * Do not use a global log handler object
fmauch
pushed a commit
that referenced
this pull request
Oct 26, 2024
* Correctly reset async_thread_shutdown when starting the async thread * Do not use a global log handler object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is closing #1097
As mentioned in the issue I would like to combine this issue with tests for lifecycle management.