Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to publish SRDF file. #1089

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

v-marsh
Copy link

@v-marsh v-marsh commented Aug 28, 2024

Added argument to the launch file that can toggle the ability to publish the contents of the SRDF on the topic /robot_description_semantic. This allows the launch file to be used with custom moveit2 projects without having to source the SRDF for every launched node.

See following link for details: https://moveit.picknik.ai/humble/doc/examples/urdf_srdf/urdf_srdf_tutorial.html#string-topic-specification

Note: The default behaviour of not publishing this topic has been maintained, but now users have the option publish it if needed.

Added argument to the launch file that can toggle the ability to publish
the contents of the SRDF on the topic /robot_description_semantic. This
allows the launch file to be used with custom moveit2 projects without
having to source the SRDF for every launched node.
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be similar to #1036. Is there a reason why you by default didn't enable this?

@v-marsh
Copy link
Author

v-marsh commented Sep 4, 2024

Because #1036 only applies to the main branch which fails to build on ros2 humble. This request applies that same change to the humble branch which is useful for projects still running on humble due to its long term support.

@fmauch
Copy link
Collaborator

fmauch commented Sep 4, 2024

Sorry, my comment was misleading. I was basically making two statements. The first being the backport of #1036. I'll make my second statement in-code to make it clear.

@v-marsh
Copy link
Author

v-marsh commented Sep 5, 2024

I agree with keeping the default value as True. The only reason I initially set it to False was to avoid changing to default API in case there is some obscure situation where publishing it resulted in certain worksflows failing to complete.

@fmauch fmauch merged commit d5ca84f into UniversalRobots:humble Sep 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants