Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify launch file for ur_bringup pkg #1004

Merged
merged 2 commits into from
May 24, 2024

Conversation

VinDp
Copy link
Collaborator

@VinDp VinDp commented May 23, 2024

Since ur_control.launch.py from ur_bringup is basically a duplicate of the one contained in ur_robot_driver, this PR makes it much simpler by reusing what is already defined in the other launch file, avoiding useless repetitions.

@VinDp VinDp requested a review from fmauch May 23, 2024 08:29
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good.

@fmauch fmauch merged commit 65a8c34 into UniversalRobots:humble May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants