Skip to content

Commit

Permalink
Remove dependency to docker.io (#985)
Browse files Browse the repository at this point in the history
* Remove dependency to docker.io

The dependency was basically added since this is needed to spawn up
ursim. However, the start_ursim script catches the case that no docker
executable is available and the tests requiring it are behind a compile
definition which is off by default.

So, in order to not install docker for users automatically, the dependency
shall be removed.

(cherry picked from commit 585e29f)
  • Loading branch information
fmauch committed May 7, 2024
1 parent c8d961e commit beeb8fa
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/humble-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ jobs:
ROS_DISTRO: ${{ matrix.ROS_DISTRO }}
ROS_REPO: ${{ matrix.ROS_REPO }}
CMAKE_ARGS: -DUR_ROBOT_DRIVER_BUILD_INTEGRATION_TESTS=ON
ADDITIONAL_DEBS: docker.io netcat-openbsd # Needed for integration tests
1 change: 1 addition & 0 deletions .github/workflows/humble-semi-binary-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ jobs:
ROS_DISTRO: ${{ matrix.ROS_DISTRO }}
ROS_REPO: ${{ matrix.ROS_REPO }}
CMAKE_ARGS: -DUR_ROBOT_DRIVER_BUILD_INTEGRATION_TESTS=ON
ADDITIONAL_DEBS: docker.io netcat-openbsd # Needed for integration tests
1 change: 0 additions & 1 deletion ur_robot_driver/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
<exec_depend>velocity_controllers</exec_depend>
<exec_depend>xacro</exec_depend>

<test_depend>docker.io</test_depend>
<test_depend>launch_testing_ament_cmake</test_depend>

<export>
Expand Down

0 comments on commit beeb8fa

Please sign in to comment.