Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responding to app requests #252

Merged
merged 40 commits into from
Aug 18, 2024
Merged

Conversation

Golem642
Copy link
Contributor

@Golem642 Golem642 commented Aug 11, 2024

Waiting for answers for the following apps (might be in a future PR instead) :

@Golem642
Copy link
Contributor Author

Currently waiting for answers on some app requests, and i don't know what to do for scummvm and retroarch

Hopefully it works, we'll have to see when downloading. I've detected no other issue while testing everything manually
@Golem642
Copy link
Contributor Author

Just checked the generated retroarch links : they are valid and updated to the latest version, so we should be all good

Changed icon link, before was 404
Removed icon, outdated discord link, was 404
Tested and working locally, links seems to be fine and everything seems to be working. We'll see on download but i think it's all good
descriptions
@Golem642
Copy link
Contributor Author

Golem642 commented Aug 12, 2024

Note : i didn't include the DS release of scummvm as there is a 3DS standalone release so i felt like the DS one wasn't necessary

Edit : i also noticed there was a retroarch core for that already, but sometimes it works better as a standalone rather than a retroarch core so i'm letting it in

Removed invisible chars that were breaking the non-utf8 reading before, just in case
@Epicpkmn11
Copy link
Member

Note : i didn't include the DS release of scummvm as there is a 3DS standalone release so i felt like the DS one wasn't necessary

Edit : i also noticed there was a retroarch core for that already, but sometimes it works better as a standalone rather than a retroarch core so i'm letting it in

U-DB is intended to be a resource for both people with 3DS's and DS/DSi’s, so DS versions of apps should be included too

@Golem642
Copy link
Contributor Author

Is there a UU for the DS ?

Replaced icon and banner with fixed links from the github repo
Added DS versions
@Golem642
Copy link
Contributor Author

@Epicpkmn11 I don't know which files UU extracts from a zip, because the normal downloads for scummvm contains a lot of other files and there's no option to select only one or put them into one place in the "downloads" section of the json. Or do i have to also include a script for normal releases downloads ?

@Golem642 Golem642 marked this pull request as ready for review August 14, 2024 13:46
@Golem642
Copy link
Contributor Author

Marking this as ready for review to atleast commit what i've got rn

Specific file extraction
Maybe this works ? missing doc
@Golem642
Copy link
Contributor Author

Ok so for scummvm i tried to search other examples of cases like this where there are different files in a zip, and i found the "archive" attribute which seems undocumented ?? but i hope it works

@Golem642
Copy link
Contributor Author

Golem642 commented Aug 16, 2024

Now i'm kinda worried about retroarch and how the files are going to be installed, there might be an empty folder residue, i'll try to download once merged and send a fix if there's an issue
If there's no objections, can someone merge ? The other 4 issues will be put in a new PR once they answer

@NightScript370 NightScript370 merged commit 8601e9e into Universal-Team:master Aug 18, 2024
@Golem642 Golem642 deleted the patch-1 branch August 18, 2024 13:52
@regimensocial
Copy link

Thank you! (from Citrahold)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants