Internal/2023.2/staging #8059
Merged
Internal/2023.2/staging #8059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with escape key Jira: UUM-61583 Steps to repro: - Create a new HDRP/URP project - Create a new VFX Graph - Create two operators that have incompatible slots (`Float` and `Sample Gradient` for instance) - Drag `Float` connection out and hover it over gradient input slot - Hit escape to cancel - Observe wrong type popup gets stuck and moves around with graph  
…n Server Builds (UUM-56965)
When running server builds calling `{GetType().DeclaringType.Name}` will give a NullReferenceException. This happens in two places inside the URP Codebase. To fix this the calls are simply removed as they don't provide much value.
Fix https://jira.unity3d.com/browse/UUM-66215 where the layout of elements in DOTS Entity Baking Preview panel changes depending on if Material foldout UI is expanded or not. When the material foldout GUI is expanded on URP or HDRP, it affects other UI drawn afterwards because the UI logic modified persistent `EditorGUIUtility.labelWidth` value and didn't restore it properly after drawing its widgets. This PR fixes that by resetting the value to 0 after drawing the material options. The fix is made separately on CoreRP (used by URP Material Editor) and HDRP because the UI has separate implementations. Note: we are simply setting the labelWidth to 0 instead of restoring whatever value it was before, because 0 is a special value that cannot be retrieved by using the property getter of `EditorGUIUtility.labelWidth` - if the internal value is 0, it will return some predetermined values instead (see [implementation](https://github.cds.internal.unity3d.com/unity/unity/blob/trunk/Editor/Mono/EditorGUIUtility.cs#L1367-L1379)). Therefore we must make the assumption that 0 is the correct value to be restored in this case.
…if color is required by the feature This is a backport of UUM-14679 and UUM-59428 https://github.cds.internal.unity3d.com/unity/unity/pull/27096 https://github.cds.internal.unity3d.com/unity/unity/pull/41673 https://github.cds.internal.unity3d.com/unity/unity/pull/43116
Add public scripting API for URP TAA settings.
…emultiplied alpha This PR fixes the issue Adds an option to multiply specular by opacity by disabling preserve specular This is not technically correct but offers similar control to transparents that are not in premultiply mode and helps for VFX. Disabling affect specular in material settings provides the same result as before, but now you have an option to get a different result, so maybe not really needed to mention in upgrade guide as now it's working more as expected (previously the option had no effect) * Bug:https://jira.unity3d.com/browse/UUM-48661 * Backport:https://jira.unity3d.com/browse/UUM-51548
…efore validating them. This PR add an extra check to `ScriptableRendererData.OnValidate` to ensure we only validate `ScriptableRendererFeatures` when all scripts have been compiled. Not doing so can lead to errors being thrown to the console during import (see attached Jira ticket). Jira: https://jira.unity3d.com/browse/UUM-58944
https://jira.unity3d.com/browse/UUM-58350 An internal operation (addComponent) was registering an editor Undo, marking the scene as dirty every time we entered the playmode.
…ming is forced depth copy after depth priming happens after screenspace shadows and it should be vice versa due to the fact, that both events are the same. this PR increases the event of screenspace shadows by one just to guarantee the correct sequencing of the passes
…(UUM-44446) Backport of #38151.
…ogic to match the non-NRP path In some edge cases, when NativeRenderPass is enabled, MSAA resolve errors are thrown, because of incorrect render target setup when using a camera target texture. This PR makes sure the same logic used in the non-NRP path is used when NRP is enabled
Currently the URP PR Aggregate job, which we run against PRs touching the URP codebase, is broken due to 4 jobs. This PR gets the URP PR Aggregate job green again by moving 3 jobs to unstable and disabling one test.
…he min/max Fix UUM-51239
…eing deallocated on scene changes. This PR fixes GameObjects allocated by HDRP (CameraCache, HDAdditionalLightData/ComponentSingletons) being deallocated in some cases on scene changes. It also slightly simplifies the Probe Camera cache to avoir re-setting the same values every frame. This fix was discussed during previous bugfix with @julien.
2023.2 model invalidation backports This PR includes fixes from several trunk PRs: - https://github.cds.internal.unity3d.com/unity/unity/pull/41986 - https://github.cds.internal.unity3d.com/unity/unity/pull/45606 - https://github.cds.internal.unity3d.com/unity/unity/pull/40877
…ositor. Added documentation on how to use the Screen Space Overlay render mode alongside the Graphics Compositor. We decided not to change the actual behavior of SupportedRenderingFeatures.active.rendersUIOverlay when the Graphics Compositor is in use, but instead, to document a way force the rendering of the UI in this context. When the user follows the new documentation steps, the UI is indeed well renderer in the GameView. Tested manually and locally on my Windows machine.
… node doc As in title
update graphics compositor limitation for VR
…d in #include files Backport of https://github.cds.internal.unity3d.com/unity/unity/pull/45790 From trunk PR: Fixes [UUM-62756](https://jira.unity3d.com/browse/UUM-62756). The public documentation states the shader compiler will ignore Unity-specific #pragma directives in files included through #include, however this behavior was broken as they were being reported in both #include and #include_with_pragmas. This change fixes that so they're not reported in #include files. Also, added a warning message when someone uses #include_with_pragmas within a file that was itself included with #include. In that particular case, #include_with_pragmas will be treated as #include, meaning all Unity-specific pragmas it might contain will be ignored. Bug: https://jira.unity3d.com/browse/UUM-62756 Backport: https://jira.unity3d.com/browse/UUM-63800
…HDRP In 2023.2, assets preview thumbnails are not rendered properly sometimes, they are gray. It's not the case in `2023.3.0a7`, it works perfectly fine. It works because of the introduced changes in this PR: https://github.cds.internal.unity3d.com/unity/unity/pull/34816 Specifically the changes for the `HDRenderPipeline.cs`. Removing the globalSettings null check in 2023.2 fixes the issue. I don't know this code area, this is definitely more a question for @alex-vazquez I have to jump in vacation this week, I apologize for that, but wanted to create this PR so I can help the next person investigating this issue. I don't mind resuming my work on it if we wanna wait a week!
…rmal packing functions. Fixes https://jira.unity3d.com/browse/UUM-62216, in which artifacts appear (looks like uninitialized memory) when using the accurate G-buffer normals feature when targeting mobile. This feature uses a pair for function for performing octrahedral encoding and decoding of normals. The function misbehaves when targeting mobile, but not desktop. The main difference between mobile and desktop in shadercode is that desktop treats `half` as float, whereas on mobile `half` actually works. The functions for octahedral encoding take `float`'s as input, and are given `half`'s in the mobile path. In the function, we use `abs()` on the input and then negate it. This combination seems to cause a miscompilation of some sort, presumably because `abs` and negation are both input modifiers rather than real instructions - I'm not entirely sure, but it's some mix of those 3 things - half to float conversion, abs and negation. The most minimal fix that worked was this: ``` float3 UnpackNormalOctQuadEncode(float2 f) { - float3 n = float3(f.x, f.y, 1.0 - abs(f.x) - abs(f.y)); + float3 n = float3(f.x, f.y, 1.0 - abs(real(f.x)) - abs(real(f.y))); ``` But I instead decided to change the functions to use `real` instead of `float` throughout, as it it seemed cleaner. `real` is just an alias for `half` on mobile and `float` on desktop.
… projector pass Fixes https://jira.unity3d.com/browse/UUM-54404, where screen space decals weren't taking into account light cookies. The code to sample cookies is already present in the relevant shader (a shader made with shadergraph decal template), but the keyword for light cookies, `_LIGHT_COOKIES` is not declared. The fix is simply to add the keyword to the relevant pass descriptor. The keyword will automatically be set earlier in the render loop, in `LightCookiesManager.Setup`.
…n the pass is "LightMode" = "Universal2D" Fix missing pass name https://jira.unity3d.com/browse/UUM-36358
…a block Jira: UUM-59123 When a block is collapsed the activation slot is not visible anymore. Before:  After:  Slack thread: https://unity.slack.com/archives/G1BTWN88Z/p1702479571472809
Fix NaN issue in volumetric fog reprojection
Fix shader warnings in URP 2D template
…t camera Set default projection orthographic for pixel perfect camera
- Bumped SRP packages from 16.0.5 to 16.0.6
…mbient) In the initial rendering of the preview in the inspector window, the ambient color of the default sky may not be ready (black ambient color), due to the lag of GPU readback of the SH coefficients. The ambient color is not updated until the preview is updated by some triggers like hovering the cursor over the inspector. This PR fixes the issue by using the hard-coded value of the default sky's SH.
…ected ### [UUM-52509](]https://jira.unity3d.com/browse/UUM-52509) Steps to repro 1. Create a new VFX Graph 2. Add position line sequential block 3. Connect to VFX to enable gizmos, in scene view select Line End gizmo 4. Move it, observe that it's still changing Line Start values Does not repro in a6. Possibly caused by https://github.cds.internal.unity3d.com/unity/unity/pull/32348
Fix a scaling issue with the recorder.
…ity changes https://jira.unity3d.com/browse/UUM-67982 The update logic in the reflection probe atlas was not taking into account the runtime intensity of non real-time probes
Backport of #47069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.