Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal/2023.1/staging #7957

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Internal/2023.1/staging #7957

merged 3 commits into from
Sep 5, 2023

Conversation

UnityAljosha
Copy link
Collaborator

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

arthur-dufay and others added 3 commits August 30, 2023 02:21
@arthur-dufay
Make sure to bind buffers of expected size to make Metal validation …
b7a201d 
This PR addresses https://jira.unity3d.com/browse/UUM-41477.

The Metal validation layer checks whether buffer bindings are 'meaningful'. For example, if you bind a buffer of size 4 to a slot which points to an array of uint3s (which has size 12), then Metal validation layer will trigger because this is not 'meaningful' (myBuffer[0] will read out of bounds).

In case of [UUM-41474](https://jira.unity3d.com/browse/UUM-41474), this meant that the whole editor crashed because ProbeReferenceVolume bound a buffer which (from Metal's point of view) was not meaningful. The fix was therefore to make sure to provide a 'meaningful' uint3 buffer in the case when needToBindNeutral = true.
@knatraj-rythmos
2023.1: Fix per-vertex light layers
b6eca71 
The emission of light from the vertex layer should not be lit in cases of a layer mismatch, but currently, the vertex layer remains illuminated regardless of the layer's compatibility. This PR addresses per-vertex light layers issue. 

Parent: https://jira.unity3d.com/browse/UUM-40810
Backport: https://jira.unity3d.com/browse/UUM-41568
@LagueKristin
[Backport 2023.1] Fix Material and Preview Prefabs light switching
bf592bb 
Fixes an issue where material previews were rendered dark and the prefab preview would show dark until the object was moved. This issue was a result of the HDAdditionalLightData not being properly initialized when the previews were rendered.

We realized this is a regression stemming from https://github.cds.internal.unity3d.com/unity/unity/pull/20119which was solving a different problem so this fix is basically an addition to it that fixes the resulting issue of dark previews.
@UnityAljosha UnityAljosha requested a review from a team as a code owner September 5, 2023 08:05
@UnityAljosha UnityAljosha merged commit 24c2b65 into 2023.1/staging Sep 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UnityAljosha @arthur-dufay @knatraj-rythmos @LagueKristin