HDRP Template fix incorrect volume used for sky baking #7941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iM0ve
requested review from
sebastienlagarde and
pierre-unity
and removed request for
pierre-unity
sebastienlagarde
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
If users rebake lighting on the template, it will look significantly more yellow. This happens because the volume assigned for baking has no sky assigned(see image below). This regression appeared after the Default Settings rework, I dont know if I need to make backport PRs for other unity versions (as the scene file might be different).
The fix
My PR simply changes what volume is used in the Lighting->Environment tab. Before the fix it was VolumeDefault(sky missing), after the fix its using VolumeGlobal(has HDRI sky).
Showcase
On project open, the template will look normal as in the image below.
If user rebakes the lighting, newly generated data will be incorrect, as seen below(yellow). After the fix it will no longer look like this.
