fix(@web3-react/gnosis-safe): bump safe sdk version to fix the signing issue #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zzmp
suggested changes
Jun 29, 2023
zzmp
approved these changes
Jun 29, 2023
zzmp
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Safe SDK version
7.10.0contains a bug related to passing the SDK version for checking if a particular feature is compatible with the SDK/safe wallet interface. This renders the uniswap's interface permit2 flow unusable because signing a message in the Safe wallet is only available from a particular version, and the SDK currently passes an invalid version number.This was fixed in
7.10.1, and in version 8, Safe SDK migrated frometherstoviemunder the hood and shaved off ~50% of the SDK package size.This PR updates the SDK version of the connector to
8.0.0and pumps the connector package version.Test plan