Introduce standard batched call under a lock #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucepoint
reviewed
Dec 12, 2023
test/SimpleBatchCallTest.t.sol
Outdated
Comment on lines
43
to
44
| bytes memory settleData = | ||
| abi.encode(SimpleBatchCall.SettleConfig({withdrawTokens: true, settleUsingTransfer: true})); |
| function _handleAfterExecute(bytes memory callReturnData, bytes memory settleReturnData) internal virtual; | ||
|
|
||
| /// @param executeData The function selectors and calldata for any of the function selectors in ICallsWithLock encoded as an array of bytes. | ||
| function execute(bytes memory executeData, bytes memory settleData) external { |
There was a problem hiding this comment.
just my opinion and happy to keep as-is, but I think we should type settleData with SettleConfig
the serialization/deserialization feels cumbersome from a devex POV
contracts/base/CallsWithLock.sol
Outdated
There was a problem hiding this comment.
i prefer cleaner function signatures so I think you can drop the WithLock suffixes
contracts/SimpleBatchCall.sol
Outdated
Comment on lines
43
to
47
| if (config.withdrawTokens) { | ||
| poolManager.mint(currency, address(this), uint256(-delta)); | ||
| } else { | ||
| poolManager.take(currency, address(this), uint256(-delta)); | ||
| } |
There was a problem hiding this comment.
this is mixed up right? withdraw=true should be take
|
Closing for now. We can create a generalized lock and batch call example for integrators in the future though. This PR will add all the SafeCallback logic though to standardize some Hook Example development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
It might be helpful for integrating contracts to have a way to call multiple functions on core under one lock. This is a start to making a standard for that.
Description of changes
I think there could be some improvements in a more standard interface for _settle and _handleAfterExecute. I wonder if there is a way we could also be passing LESS data up and back.. lmk thoughts/improvements/suggestions