-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v4 NonfungiblePositionManager skeleton #76
Closed
+756
−0
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
fe9305e
add helper contracts and interfaces for position manager
tinaszheng 0b01a0a
run forge fmt
tinaszheng 74ad1a2
remove custom timestamp getter
tinaszheng 30479c6
use custom errors and IER1271.isValidSignature.selector
tinaszheng 349ddb8
use using .. for syntax for TransferHelper
tinaszheng 906fb65
add erics custom error handler
tinaszheng 0152e5c
remove ChainId library
tinaszheng e5fc9dd
use currency library to combine sweepETH and sweepToken
tinaszheng 54d55fd
use Currency library for pay method
tinaszheng a2200ac
use solmate SafeTransferLib instead
tinaszheng b4f84ee
remove erc721permit for now
tinaszheng ad5c503
revert changes to TransferHelper
tinaszheng 04a7a1d
put using .. for in contract header
tinaszheng f9d830e
move custom errors inside contracts
tinaszheng 0d87708
run format
tinaszheng 02a5cd2
update version
tinaszheng d261d58
add v4 position manager contracts
tinaszheng 7f544b1
add Currency class and fix override error
tinaszheng 7cc8c66
remove reference to erc721enumerable from concrete
tinaszheng c52f05a
use custom errors
tinaszheng 05c9543
use ERC721 for now
tinaszheng ca01507
move custom errors inside contract + inherit from ILockCallback
tinaszheng 4a7d82a
use poolkey in mint params
tinaszheng 6e82a2e
rename variables
tinaszheng 3166045
add periphery immutable state
tinaszheng ad34755
update position manager skeleton with liquidity management file
tinaszheng aad107a
fix inheritance order
tinaszheng 87e0b2f
move stuff around
tinaszheng c64e82e
move addLiquidity functions to liquiditymanagement
tinaszheng b72452b
update comment + delete unused file
tinaszheng 5d8a888
remove stuff for initializing pools for now
tinaszheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
use solmate SafeTransferLib instead
commit a2200ac70208f4a580771c09287ebe88b3135983
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to use Permit2 for this? or are we good with approve and transferFrom?