add compilation restrictions #402

gretzke · 2024-11-26T02:19:47Z

No description provided.

src/interfaces/IPoolInitializer.sol

src/PositionDescriptor.sol

Co-authored-by: Louis Brown <[email protected]>

src/interfaces/IPositionDescriptor.sol

src/interfaces/IPositionManager.sol

dianakocsis · 2024-11-27T17:47:47Z

could be removed

v4-periphery/test/shared/Planner.sol

Line 6 in d1d087f

import {IPositionManager} from "../../src/interfaces/IPositionManager.sol";

dianakocsis · 2024-11-27T17:51:31Z

getting warnings on these:

v4-periphery/test/mocks/MockBadSubscribers.sol

Line 51 in d1d087f

    
           function notifyBurn(uint256 tokenId, address owner, PositionInfo info, uint256 liquidity, BalanceDelta feesAccrued)

v4-periphery/test/mocks/MockBadSubscribers.sol

Line 95 in d1d087f

    
           function notifyBurn(uint256 tokenId, address owner, PositionInfo info, uint256 liquidity, BalanceDelta feesAccrued)

v4-periphery/test/mocks/MockSubscriber.sol

Line 50 in d1d087f

    
           function notifyBurn(uint256 tokenId, address owner, PositionInfo info, uint256 liquidity, BalanceDelta feesAccrued)

src/interfaces/IPoolInitializer.sol

test/mocks/MockReenterHook.sol

test/position-managers/NativeToken.t.sol

test/position-managers/Permit.t.sol

test/position-managers/PositionManager.multicall.t.sol

test/position-managers/PositionManager.modifyLiquidities.t.sol

foundry.toml

test/shared/Deploy.sol

Co-authored-by: Alice <[email protected]>

src/interfaces/IPoolInitializer.sol

src/base/UnorderedNonce.sol

test/position-managers/PositionManager.modifyLiquidities.t.sol

test/shared/Deploy.sol

saucepoint

looks pretty good to me; did NOT look at PositionDescriptor.t.sol btw 😅

script/DeployStateView.s.sol

script/DeployV4Quoter.s.sol

src/interfaces/IPositionDescriptor.sol

src/interfaces/IPoolInitializer.sol

src/interfaces/IStateView.sol

test/position-managers/PositionManager.modifyLiquidities.t.sol

src/interfaces/IPermit2Forwarder.sol

dianakocsis · 2024-12-09T18:37:56Z

src/interfaces/IPermit2Forwarder.sol

+
+import {IAllowanceTransfer} from "permit2/src/interfaces/IAllowanceTransfer.sol";
+
+/// @notice Permit2Forwarder allows permitting this contract as a spender on permit2


this is the exact same natspec as Permit2Forwarder. I feel like the top of interfaces should all be the same, maybe like how it is for IPositionManager.sol.

/// @title IPermit2Forwarder /// @notice Interface for the Permit2Forwarder contract

and then we can follow this standard across all of our interfaces, and then the natspec at the top of the contracts could go in more detail?

add compilation restrictions

f920107

gretzke requested review from hensha256 and snreynolds November 26, 2024 02:19

louisbrown0212 reviewed Nov 26, 2024

View reviewed changes

src/interfaces/IPoolInitializer.sol Outdated Show resolved Hide resolved

louisbrown0212 reviewed Nov 26, 2024

View reviewed changes

src/PositionDescriptor.sol Outdated Show resolved Hide resolved

gretzke and others added 4 commits November 26, 2024 22:04

optimize compiler runs

e67c0e6

Update src/interfaces/IPoolInitializer.sol

2a4d7fa

Co-authored-by: Louis Brown <[email protected]>

remove override

272d078

regenerate gas snapshots

d1d087f

dianakocsis reviewed Nov 27, 2024

View reviewed changes

src/interfaces/IPositionDescriptor.sol Outdated Show resolved Hide resolved

dianakocsis reviewed Nov 27, 2024

View reviewed changes

src/interfaces/IPositionManager.sol Show resolved Hide resolved