Assembly length checks #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
commented
Nov 22, 2024
test/libraries/CalldataDecoder.t.sol
Outdated
| decoder.decodeUint256(invalidParams); | ||
| } | ||
|
|
||
| function test_fuzz_decodeCurrencyUint256AndBool(Currency _currency, uint256 _amount, bool _boolean) public { |
There was a problem hiding this comment.
this test shouldve been here before... was just missing 🤷♀️
0age
reviewed
Nov 22, 2024
| @@ -136,6 +140,12 @@ library CalldataDecoder { | |||
| { | |||
| // ExactInputParams is a variable length struct so we just have to look up its location | |||
| assembly ("memory-safe") { | |||
| // only safety checks for the minimum length, where path is empty | |||
| // 0xa0 = 5 * 0x20 -> 3 elements, path offset, and path length 0 | |||
| if lt(params.length, 0xa0) { | |||
There was a problem hiding this comment.
since params.length is calldataload(params.offset) we might be able to save some gas by just getting that once and then reusing the value for both the check and the copy
There was a problem hiding this comment.
update: params.offset holds the offset of where the content of the dynamic field starts, not the length
There was a problem hiding this comment.
ah that's right! gains would be minimal if at all anyway 🙃
0age
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.