Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to use native snapshots #385

Merged
merged 15 commits into from
Dec 6, 2024
Merged

feat: update to use native snapshots #385

merged 15 commits into from
Dec 6, 2024

Conversation

marktoda
Copy link
Contributor

Related Issue

Which issue does this pull request resolve?

Description of changes

snreynolds
snreynolds previously approved these changes Oct 24, 2024
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiice

@marktoda marktoda force-pushed the update-native-snaps branch from 5b2ee0c to 589b92e Compare October 30, 2024 15:36
@marktoda marktoda marked this pull request as draft October 30, 2024 16:41
@marktoda marktoda marked this pull request as ready for review November 1, 2024 15:32
@snreynolds snreynolds requested a review from hensha256 December 4, 2024 19:09
@@ -1,5 +1,4 @@
@uniswap/v4-core/=lib/v4-core/
forge-gas-snapshot/=lib/forge-gas-snapshot/src/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to delete the submodule 👀

@snreynolds snreynolds merged commit 51df60a into main Dec 6, 2024
3 checks passed
@snreynolds snreynolds deleted the update-native-snaps branch December 6, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants