Pashov L-06 limit symbol length #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Oct 24, 2024
hensha256
reviewed
Oct 28, 2024
| @@ -92,4 +97,16 @@ library SafeCurrencyMetadata { | |||
| } | |||
| return ""; | |||
| } | |||
|
|
|||
| /// @notice truncates the symbol to the MAX_SYMBOL_LENGTH | |||
| /// @param str the symbol | |||
There was a problem hiding this comment.
would be great to have 1 little
@dev assumes the string is already longer than MAX_SYMBOL_LENGTH
hensha256
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Pashov L-06 https://github.com/PashovAuditGroup/Uniswap_October_MERGED/issues/10
Long symbol strings can cause tokenURI to revert or artifacts in the SVG image
Description of changes
limit symbol length