Add wrap, unwrap functionality #369
Conversation
src/base/NativeWrapper.sol
Outdated
| } | ||
|
|
||
| function wrap(uint256 _amount) external payable { | ||
| uint256 amount = _amount == ActionConstants.CONTRACT_BALANCE ? address(this).balance : _amount; |
There was a problem hiding this comment.
might be worth added 2 extra checks to each of these functions
- if
amount > balancerevert - so that theres a nice custom error? - only deposit (or withdraw) if
amount != 0. As someone might pass inCONTRACT_BALANCEand the current balance is 0 so then deposit/withdraw shouldnt be called
So maybe like
if (amount == ActionConstants.CONTRACT_BALANCE) {
amount = address(this).balance;
} else if (amount > address(this).balance) {
revert InsufficientETH();
}
if (amount > 0) WETH9.deposit{value: amount}();
| /// @notice Calculates the sanitized amount before wrapping/unwrapping. | ||
| /// @param inputCurrency The currency, either native or wrapped native, that the contract holds | ||
| /// @param amount The amount to wrap or unwrap. Can be CONTRACT_BALANCE or OPEN_DELTA or a specific amount | ||
| /// @param outputCurrency The currency after the wrap/unwrap that the user may owe a balance in on the poolManager |
There was a problem hiding this comment.
| /// @param outputCurrency The currency after the wrap/unwrap that the user may owe a balance in on the poolManager | |
| /// @param outputCurrency The currency after the wrap/unwrap |
There was a problem hiding this comment.
They also could be wrapping/unwrapping before sweeping to themselves etc. I feel like theres a few valid use-cases so shouldnt single one out
There was a problem hiding this comment.
yeah but outputCurrency is only used to get the OPEN_DELTA balance on the contract
There was a problem hiding this comment.
i didn't change this but lmk i can change if you still think so after reading this comment above^
There was a problem hiding this comment.
i see, maybe it could be clearer to say something that describes that better like
The currency after the wrap/unwrap, used when amount is OPEN_DELTA to look up the balance owed to the poolManager
or something like that?
| @@ -308,4 +329,114 @@ contract PositionManagerModifyLiquiditiesTest is Test, PosmTestSetup, LiquidityF | |||
| ); | |||
| lpm.modifyLiquidities(calls, _deadline); | |||
| } | |||
|
|
|||
| function test_weth_wrap_increaseLiquidity() public { | |||
There was a problem hiding this comment.
would love to see a test case that uses OPEN_DELTA to test that flow works too
Related Issue
Which issue does this pull request resolve?
Description of changes