Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position descriptor #353
Position descriptor #353
Changes from 45 commits
2434576
c423b33
e497389
830fdf5
8eb66b3
7e8fc42
f94823f
a77fb26
547c893
e695f43
df58a26
d6d1353
7fd6b5b
84cc704
ec4ebdd
5a88042
fe1d709
31a22de
ca37b8c
ec14729
21ae901
b29c5fe
a2bc1b2
e6315a3
e7eb9f0
69208ec
e6dfb70
9b723c3
7d69f53
0ba4e38
2b518bf
04b719a
7e110cc
924d12e
a6af3b7
69af352
04b458e
9ff5137
8506989
4542c59
d0b81fe
4d53d2a
e4ccd57
a4892e3
c08ccd9
40904b0
8a6033e
6ff9887
8ea6b67
072102f
bd90cee
f72f195
c10da46
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think id rather this logic was inside the namer. Like SafeCurrencyNamer and then in there check
.isAddressZero()
to abstract away from this contractThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so have the isAddressZero check inside of the namer? that's not directly related to name though. Plus, the isAddressZero check is also used for decimals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm wondering if
SafeERC20Namer
should be called likeSafeCurrencyMetadata
or something?and then it can include
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is safe decimal fetching not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure because for name we check to see if its returned in bytes and then convert it to string.
i guess we could do something similar for uint8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how likely that decimals will be in bytes tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but what if the token doesnt have a decimals function? they dont have to. I think you have to default it to 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you look at the spec the function is optional. So you can do a try-catch and default to 0 or something