Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add updated deploys #350

Closed
wants to merge 2 commits into from
Closed

add updated deploys #350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8fa900
add updated deploys
snreynolds Sep 11, 2024
0b0d66f
Merge branch 'main' into updated-deploys
snreynolds Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ cache/
foundry-out/
.vscode/
broadcast/*/*/dry-run/*.json
broadcast/*/*/run-[0-9]*.json
broadcast/*/*/run-[0-9]*.json
.env
50 changes: 24 additions & 26 deletions broadcast/01_PoolManager.s.sol/11155111/run-latest.json
View file
Open in desktop

Large diffs are not rendered by default.

43 changes: 24 additions & 19 deletions broadcast/02_PoolModifyLiquidityTest.s.sol/11155111/run-latest.json
View file
Open in desktop

Large diffs are not rendered by default.

43 changes: 24 additions & 19 deletions broadcast/03_PoolSwapTest.s.sol/11155111/run-latest.json
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 56 additions & 0 deletions broadcast/DeployPosm.s.sol/11155111/run-latest.json
View file
Open in desktop

Large diffs are not rendered by default.

34 changes: 17 additions & 17 deletions broadcast/DeployStateView.s.sol/11155111/run-latest.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions script/DeployPosm.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {StateView} from "../src/lens/StateView.sol";
import {PositionManager} from "../src/PositionManager.sol";
import {IAllowanceTransfer} from "permit2/src/interfaces/IAllowanceTransfer.sol";

contract DeployPosmTest is Script {
contract DeployPosm is Script {
function setUp() public {}

function run(address poolManager, address permit2, uint256 unsubscribeGasLimit)
Expand All @@ -18,7 +18,7 @@ contract DeployPosmTest is Script {
{
vm.startBroadcast();

posm = new PositionManager{salt: hex"03"}(
posm = new PositionManager{salt: hex"01"}(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just use create1 to stop needing to change the salt every time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually usually don't need to change the salts each time bc the bytecode is so different from deploy to deploy. On posm I started using salt when I was testing to see how different ascii look on etherscan 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont wanna change that though bc we've deployed the current deploys with create2 so nice to have a record in this PR what salt it was deployed with

IPoolManager(poolManager), IAllowanceTransfer(permit2), unsubscribeGasLimit
);
console2.log("PositionManager", address(posm));
Expand Down
Loading