Spearbit 99 #339
Merged
Spearbit 99 #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Sep 5, 2024
There was a problem hiding this comment.
this looks good.
it pains me that we don't use the mapTakeAmount and mapSettleAmount functions that we define in DeltaResolver.sol but I think its cause they added quite a bit more gas with extra casting. I wonder if we could overload those functions for uint128s now that we want to continue this logic in other places?
snreynolds
reviewed
Sep 5, 2024
snreynolds
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Spearbit 99 _swapExactOutput... does not compare the params.amountOut to ActionConstants.OPEN_DELTA
https://github.com/spearbit-audits/review-uniswap-v4/issues/99
Description of changes
compare params.amountOut to ActionConstants.OPEN_DELTA