sb-i74 #325
Merged
sb-i74 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianakocsis
commented
Aug 31, 2024
| @@ -46,6 +46,11 @@ contract EIP712_v4 is IEIP712_v4 { | |||
| mstore(add(fmp, 0x02), domainSeparator) | |||
There was a problem hiding this comment.
@hensha256 when is it left packed vs right packed?
There was a problem hiding this comment.
bytes are left-aligned, numbers and addresses are right-aligned. So the line above this
mstore(fmp, hex"1901")
stores 0x1901 in [fmp..fmp+2)
whereas if you wrote
mstore(fmp, 6401) // 6401 == 0x1901
it would right align it into [fmp+30..fmp+32)
There was a problem hiding this comment.
In fact even just mstore(fmp, 0x1901) would right align it because 0x1901 gets compiled as a number. You have to write hex"1901" for it to compile it as bytes and left-align
hensha256
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Spearbit I-74 Memory Cleaning
https://github.com/spearbit-audits/review-uniswap-v4/issues/74
Description of changes
clean the memory we used