Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ N-16 #322

Merged
merged 1 commit into from
Aug 30, 2024
Merged

OZ N-16 #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/base/BaseActionsRouter.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ abstract contract BaseActionsRouter is SafeCallback {
/// @notice function that returns address considered executer of the actions
/// @dev The other context functions, _msgData and _msgValue, are not supported by this contract
/// In many contracts this will be the address that calls the initial entry point that calls `_executeActions`
/// `msg.sender` shouldnt be used, as this will be the v4 pool manager contract that calls `unlockCallback`
/// `msg.sender` shouldn't be used, as this will be the v4 pool manager contract that calls `unlockCallback`
/// If using ReentrancyLock.sol, this function can return _getLocker()
function msgSender() public view virtual returns (address);

Expand Down
2 changes: 1 addition & 1 deletion src/libraries/CalldataDecoder.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ library CalldataDecoder {

// Calculate how far `params` is into the provided bytes
let relativeOffset := sub(params.offset, _bytes.offset)
// Check that that isnt longer than the bytes themselves, or revert
// Check that that isn't longer than the bytes themselves, or revert
if lt(_bytes.length, add(params.length, relativeOffset)) {
mstore(0, SLICE_ERROR_SELECTOR)
revert(0, 0x04)
Expand Down
Loading