Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OZ L-11 #311

Merged
merged 4 commits into from
Aug 29, 2024
Merged

OZ L-11 #311

merged 4 commits into from
Aug 29, 2024

Conversation

dianakocsis
Copy link
Contributor

Related Issue

OZ L-11 Discrepancies Between Interfaces and Implementation Contracts
https://defender.openzeppelin.com/v2/#/audit/43d4e491-c5b4-42ba-b0fc-7f5adc46a6b6/issues/L-11

Description of changes

fix discrepancies between interfaces and implementation contracts

@dianakocsis dianakocsis requested a review from saucepoint August 28, 2024 14:27
saucepoint
saucepoint reviewed Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@saucepoint saucepoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also:

    @inheritdoc BaseActionsRouter
    function msgSender() public view override returns (address) {
        return _getLocker();
    }

src/base/EIP712_v4.sol Outdated
Comment on lines 29 to 30
/// @notice Returns the domain separator for the current chain.
/// @dev Uses cached version if chainid is unchanged from construction.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove now that we're inheriting from the interface

src/lens/Quoter.sol Outdated
function quoteExactInputSingle(QuoteExactSingleParams memory params)
function quoteExactInputSingle(QuoteExactSingleParams calldata params)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the OZ issue, i think we wanted memory on both implementation and interface. I think there were incidents in IQuoter that were using calldata.

Because we are redoing Quoter entirely, i dont think we need to change it back

@dianakocsis dianakocsis requested a review from saucepoint August 28, 2024 19:56
@dianakocsis dianakocsis merged commit 3c626c2 into main Aug 29, 2024
3 checks passed
@dianakocsis dianakocsis deleted the oz-L11 branch August 29, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saucepoint saucepoint saucepoint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianakocsis @saucepoint