Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reverse mapping for pool key, store tL, tU #310

Merged
merged 29 commits into from
Sep 5, 2024
Merged

feat: add reverse mapping for pool key, store tL, tU #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c423b33
messy checkpoint
snreynolds Aug 28, 2024
e497389
update subscribers
snreynolds Aug 28, 2024
830fdf5
stack too deep, permit error
snreynolds Aug 28, 2024
8eb66b3
use packed, no via-ir, but stack too deep concerning for tests
snreynolds Aug 29, 2024
7e8fc42
use external
snreynolds Aug 29, 2024
f94823f
review comments
snreynolds Aug 29, 2024
a77fb26
merge confs
snreynolds Aug 29, 2024
547c893
clear lower 8 bits on unsubscribe
snreynolds Aug 29, 2024
e695f43
move _pay, minimize diff
snreynolds Aug 29, 2024
df58a26
pr comments
snreynolds Aug 29, 2024
d6d1353
fix: test_fuzz_erc721Permit_SignatureDeadlineExpired
snreynolds Aug 29, 2024
7fd6b5b
naming
snreynolds Aug 29, 2024
84cc704
fix
snreynolds Aug 29, 2024
ec4ebdd
natspec
snreynolds Aug 29, 2024
5a88042
fix: stack too deep in tests
snreynolds Aug 29, 2024
fe1d709
remove console
snreynolds Aug 29, 2024
31a22de
merge main
snreynolds Aug 29, 2024
ca37b8c
move PositionConfig to shared testing infra
snreynolds Aug 29, 2024
ec14729
remove pool key checker lib
snreynolds Aug 29, 2024
21ae901
pr commmeeennnnttsss
snreynolds Aug 29, 2024
b29c5fe
fmt
snreynolds Aug 29, 2024
ca8aea7
fix: merge conflicts
snreynolds Sep 5, 2024
2200534
remove mask
snreynolds Sep 5, 2024
48f5376
comments
snreynolds Sep 5, 2024
89957f4
remove comment
snreynolds Sep 5, 2024
d995a11
comments
snreynolds Sep 5, 2024
c87fd9e
fix conflicts
snreynolds Sep 5, 2024
0f2bf0c
merge conflicts
snreynolds Sep 5, 2024
c256823
add mask 200 bits
snreynolds Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .forge-snapshots/Payments_swap_settleFromCaller_takeAllToMsgSender.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
129465
129314
2 changes: 1 addition & 1 deletion .forge-snapshots/Payments_swap_settleFromCaller_takeAllToSpecifiedAddress.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
131383
131232
2 changes: 1 addition & 1 deletion .forge-snapshots/Payments_swap_settleWithBalance_takeAllToMsgSender.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
123588
123437
2 changes: 1 addition & 1 deletion .forge-snapshots/Payments_swap_settleWithBalance_takeAllToSpecifiedAddress.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
123730
123579
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_empty.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
47152
50179
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_empty_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
46970
50179
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_nonEmpty_native_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
122397
125084
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_nonEmpty_native_withTakePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
121968
124645
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_nonEmpty_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
129430
131935
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_burn_nonEmpty_withTakePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
129000
131496
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_collect_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
141457
145670
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_collect_sameRange.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
150248
154233
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_collect_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
150248
154233
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_collect_withTakePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
149699
153696
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decreaseLiquidity_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
108111
111481
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decreaseLiquidity_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
115144
119114
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decreaseLiquidity_withTakePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
114704
118577
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decrease_burnEmpty.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
133217
134624
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decrease_burnEmpty_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
126002
127773
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decrease_sameRange_allLiquidity.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
127816
131801
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_decrease_take_take.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
115704
119690
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increaseLiquidity_erc20_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
154710
158393
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increaseLiquidity_erc20_withSettlePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
153768
157475
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increaseLiquidity_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
136161
140223
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increase_autocompoundExactUnclaimedFees.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
132017
136002
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increase_autocompoundExcessFeesCredit.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
172721
176706
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_increase_autocompound_clearExcess.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
143403
147388
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
339859
364087
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_nativeWithSweep_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
348239
372467
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_nativeWithSweep_withSettlePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
347605
371833
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_onSameTickLower.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
318177
316932
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_onSameTickUpper.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
318847
317602
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_sameRange.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
244416
243171
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_settleWithBalance_sweep.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
374102
418079
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_warmedPool_differentRange.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
324208
322963
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_withClose.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
375508
419485
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_mint_withSettlePair.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
374708
418685
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_multicall_initialize_mint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
419655
463653
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_subscribe.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
88052
84348
2 changes: 1 addition & 1 deletion .forge-snapshots/PositionManager_unsubscribe.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
62411
59238
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactIn1Hop_nativeOut.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
115662
115511
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactIn1Hop_oneForZero.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
124477
124326
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactIn1Hop_zeroForOne.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
130195
130044
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactIn2Hops.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
179203
179052
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactIn3Hops.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
228190
228039
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactInputSingle.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
129465
129314
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactInputSingle_nativeOut.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
114901
114750
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactOut1Hop_nativeOut.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
116714
116563
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactOut1Hop_oneForZero.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
125529
125378
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactOut1Hop_zeroForOne.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
129446
129295
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactOut2Hops.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
179274
179123
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactOut3Hops.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
229109
228958
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactOut3Hops_nativeOut.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
220318
220167
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactOutputSingle.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
128716
128565
2 changes: 1 addition & 1 deletion .forge-snapshots/V4Router_ExactOutputSingle_nativeOut.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
116059
115908
2 changes: 1 addition & 1 deletion lib/v4-core
Open in desktop
Submodule v4-core updated 28 files
+1 −1 .forge-snapshots/add liquidity to already existing position with salt.snap
+1 −1 .forge-snapshots/addLiquidity CA fee.snap
+1 −1 .forge-snapshots/addLiquidity with empty hook.snap
+1 −1 .forge-snapshots/addLiquidity with native token.snap
+1 −1 .forge-snapshots/create new liquidity to a position with salt.snap
+1 −1 .forge-snapshots/donate gas with 1 token.snap
+1 −1 .forge-snapshots/donate gas with 2 tokens.snap
+1 −1 .forge-snapshots/poolManager bytecode size.snap
+1 −1 .forge-snapshots/simple addLiquidity second addition same range.snap
+1 −1 .forge-snapshots/simple addLiquidity.snap
+1 −1 .forge-snapshots/simple swap.snap
+1 −1 .forge-snapshots/swap CA custom curve + swap noop.snap
+1 −1 .forge-snapshots/swap CA fee on unspecified.snap
+1 −1 .forge-snapshots/swap against liquidity.snap
+1 −1 .forge-snapshots/swap mint native output as 6909.snap
+1 −1 .forge-snapshots/swap mint output as 6909.snap
+1 −1 .forge-snapshots/swap skips hook call if hook is caller.snap
+1 −1 .forge-snapshots/swap with dynamic fee.snap
+1 −1 .forge-snapshots/swap with hooks.snap
+1 −1 .forge-snapshots/swap with lp fee and protocol fee.snap
+1 −1 .forge-snapshots/swap with return dynamic fee.snap
+1 −1 .forge-snapshots/update dynamic fee in before swap.snap
+11 −6 src/PoolManager.sol
+2 −1 src/interfaces/IPoolManager.sol
+0 −9 src/libraries/CurrencyReserves.sol
+8 −4 src/test/ProxyPoolManager.sol
+5 −5 test/PoolManager.t.sol
+88 −7 test/Sync.t.sol
Loading
Loading