Provide feesAccrued to subscriber.notifyModifyLiquidity #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Aug 6, 2024
src/PositionManager.sol
Outdated
| @@ -345,7 +346,7 @@ contract PositionManager is | |||
| ); | |||
|
|
|||
| if (positionConfigs.hasSubscriber(uint256(salt))) { | |||
| _notifyModifyLiquidity(uint256(salt), config, liquidityChange); | |||
| _notifyModifyLiquidity(uint256(salt), config, liquidityChange, liquidityDelta, feesAccrued); | |||
There was a problem hiding this comment.
I am leaning on taking out liquidityDelta?
saucepoint
changed the title
snreynolds
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Provide
feesAccruedto subscribers. Considering subscribers are staking modules, this will be may be valuable informationDescription of changes
feesAccruedto subscribers innotifyModifyLiquidityResolved Question:
Do we need to provideliquidityChangeANDliquidityDelta, it's possible to convert between the two viaLiquidityAmounts