Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove recipient from QuoteParams #241

Merged
merged 2 commits into from
Aug 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/interfaces/IQuoter.sol
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ interface IQuoter {
struct QuoteExactSingleParams {
PoolKey poolKey;
bool zeroForOne;
address recipient;
uint128 exactAmount;
uint160 sqrtPriceLimitX96;
bytes hookData;
Expand All @@ -35,15 +34,13 @@ interface IQuoter {
struct QuoteExactParams {
Currency exactCurrency;
PathKey[] path;
address recipient;
uint128 exactAmount;
}

/// @notice Returns the delta amounts for a given exact input swap of a single pool
/// @param params The params for the quote, encoded as `QuoteExactInputSingleParams`
/// poolKey The key for identifying a V4 pool
/// zeroForOne If the swap is from currency0 to currency1
/// recipient The intended recipient of the output tokens
/// exactAmount The desired input amount
/// sqrtPriceLimitX96 The price limit of the pool that cannot be exceeded by the swap
/// hookData arbitrary hookData to pass into the associated hooks
Expand All @@ -58,7 +55,6 @@ interface IQuoter {
/// @param params the params for the quote, encoded as 'QuoteExactInputParams'
/// currencyIn The input currency of the swap
/// path The path of the swap encoded as PathKeys that contains currency, fee, tickSpacing, and hook info
/// recipient The intended recipient of the output tokens
/// exactAmount The desired input amount
/// @return deltaAmounts Delta amounts along the path resulted from the swap
/// @return sqrtPriceX96AfterList List of the sqrt price after the swap for each pool in the path
Expand All @@ -75,7 +71,6 @@ interface IQuoter {
/// @param params The params for the quote, encoded as `QuoteExactOutputSingleParams`
/// poolKey The key for identifying a V4 pool
/// zeroForOne If the swap is from currency0 to currency1
/// recipient The intended recipient of the output tokens
/// exactAmount The desired input amount
/// sqrtPriceLimitX96 The price limit of the pool that cannot be exceeded by the swap
/// hookData arbitrary hookData to pass into the associated hooks
Expand All @@ -90,7 +85,6 @@ interface IQuoter {
/// @param params the params for the quote, encoded as 'QuoteExactOutputParams'
/// currencyOut The output currency of the swap
/// path The path of the swap encoded as PathKeys that contains currency, fee, tickSpacing, and hook info
/// recipient The intended recipient of the output tokens
/// exactAmount The desired output amount
/// @return deltaAmounts Delta amounts along the path resulted from the swap
/// @return sqrtPriceX96AfterList List of the sqrt price after the swap for each pool in the path
Expand Down
4 changes: 0 additions & 4 deletions test/Quoter.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ contract QuoterTest is Test, Deployers {
IQuoter.QuoteExactSingleParams({
poolKey: key02,
zeroForOne: true,
recipient: address(this),
exactAmount: uint128(amountIn),
sqrtPriceLimitX96: 0,
hookData: ZERO_BYTES
Expand All @@ -111,7 +110,6 @@ contract QuoterTest is Test, Deployers {
IQuoter.QuoteExactSingleParams({
poolKey: key02,
zeroForOne: false,
recipient: address(this),
exactAmount: uint128(amountIn),
sqrtPriceLimitX96: 0,
hookData: ZERO_BYTES
Expand Down Expand Up @@ -327,7 +325,6 @@ contract QuoterTest is Test, Deployers {
IQuoter.QuoteExactSingleParams({
poolKey: key01,
zeroForOne: true,
recipient: address(this),
exactAmount: type(uint128).max,
sqrtPriceLimitX96: SQRT_PRICE_100_102,
hookData: ZERO_BYTES
Expand All @@ -345,7 +342,6 @@ contract QuoterTest is Test, Deployers {
IQuoter.QuoteExactSingleParams({
poolKey: key01,
zeroForOne: false,
recipient: address(this),
exactAmount: type(uint128).max,
sqrtPriceLimitX96: SQRT_PRICE_102_100,
hookData: ZERO_BYTES
Expand Down
Loading