multicall: bubble up revert reason #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Aug 1, 2024
src/base/Multicall.sol
Outdated
| @@ -20,7 +26,7 @@ abstract contract Multicall is IMulticall { | |||
| } | |||
| } | |||
| // Next 5 lines from https://ethereum.stackexchange.com/a/83577 | |||
| if (result.length < 68) revert(); | |||
| if (result.length < 68) CallFailed.selector.bubbleUpAndRevertWith(); | |||
There was a problem hiding this comment.
not sure about this 68 length check.. but why wouldnt we want to bubble up if > 68 ?
There was a problem hiding this comment.
because in old-solidity errors couldnt be less than 68 bytes, so it meant there was no error to bubble
snreynolds
reviewed
Aug 1, 2024
snreynolds
approved these changes
Aug 3, 2024
| // confirm expected length of the revert | ||
| try multicall.revertWithBytes(data) {} | ||
| catch (bytes memory reason) { | ||
| // errors with 0 bytes are by default 64 bytes of data (length & pointer?) + 4 bytes of selector |
There was a problem hiding this comment.
errors with 0 bytes of data outside the selector? thats super interesting.. didnt know that i guess that explains the 68 number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #175
Description of changes
Modify Multicall.sol to bubble up custom reverts with arguments