PosM: owner-level nonce for permit #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* consolidate using owner, update burn * fix: accrue deltas to caller in increase
* rip out vanilla and benchmark * fix gas benchmark * check posm is the locker before allowing access to external functions * restore execute tests * posm takes as 6909; remove legacy deadcode * restore tests * move helpers to the same file
snreynolds
reviewed
Jul 9, 2024
| @@ -96,7 +96,7 @@ contract NonfungiblePositionManager is INonfungiblePositionManager, BaseLiquidit | |||
| // mint receipt token | |||
| uint256 tokenId; | |||
| _mint(owner, (tokenId = nextTokenId++)); | |||
| tokenPositions[tokenId] = TokenPosition({owner: owner, range: range}); | |||
| tokenPositions[tokenId] = TokenPosition({owner: owner, range: range, operator: address(0x0)}); | |||
There was a problem hiding this comment.
if you mint, maybe you should be allowed to specify a default operator? maybe thats wack though lol
snreynolds
reviewed
Jul 9, 2024
contracts/base/ERC721Permit.sol
Outdated
| @@ -11,8 +11,7 @@ import {IERC1271} from "../interfaces/external/IERC1271.sol"; | |||
| /// @title ERC721 with permit | |||
| /// @notice Nonfungible tokens that support an approve via signature, i.e. permit | |||
| abstract contract ERC721Permit is ERC721, IERC721Permit { | |||
| /// @dev Gets the current nonce for a token ID and then increments it, returning the original value | |||
| function _getAndIncrementNonce(uint256 tokenId) internal virtual returns (uint256); | |||
| mapping(address owner => uint256 nonce) public nonce; | |||
There was a problem hiding this comment.
Also we will not be doing nonce per owner no? We are doing the bitmap I thought
Base automatically changed from
sauce/posm-batch-execute-transient
to
sauce/posm-batch-execute
July 9, 2024 16:03
|
Can you open this against dev-posm? |
|
Closing in favor of #153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in v3, the nonce for
permitwas at the token level and managed byNonfungiblePositionManager. This was gas-inefficient where a user paid clean / cold-storage writes for each position.in v4, we're putting the nonce at the owner level in
ERC721Permit-- enabling a one-time cold-storage write, regardless of token / pool.