Move gas snapshots to snapLastCall and forge test --isolate #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucepoint
reviewed
Jun 27, 2024
There was a problem hiding this comment.
looking at the branch locally, theres still some snapEnd(); calls in this file -- any reason why we arent changing those?
There was a problem hiding this comment.
i noticed it as a pattern in v4-core where single tests would still use snapEnd
i wasn't sure, but is there a reason for that?
saucepoint
previously approved these changes
Jul 16, 2024
Jun1on
force-pushed
the
113-move-gas-snapshots-to-snaplastcall-and-forge-test-isolate
branch
from
f63b73f to
261688e
Compare
…orge-test-isolate merge
|
closing in favor of native snapshots! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.