Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hook helpers library #116

Closed
wants to merge 1 commit into from
Closed

add hook helpers library #116

wants to merge 1 commit into from

Conversation

xyek
Copy link

@xyek xyek commented May 28, 2024

This PR adds hook helper library which automates the calculation of flags in the deployment/testing scripts.

@saucepoint
Copy link
Collaborator

hi thanks for the PR!

i think this syntax is interesting, but we're likely to move hook test deployments to use foundry cheatcodes (deployCodeTo)

@xyek
Copy link
Author

xyek commented Jun 4, 2024

That makes sense, how would the deployCodeTo address be calculated? Just this code to be updated right?

Do you think I can do that in this PR? Or is it in the works already?

@saucepoint
Copy link
Collaborator

the PR to move to deployCodeTo lives here #122

taking a look at this PR again, I'm quite hesitant on defining an arbitrary solidity function outside of a contract. The pattern feels a little too unnatural

if my understanding is correct, this PR lets hook developers adjust their flags in 1 place without needing to update test & scripts. Useful, but I dont think hook developers are changing their flags all that often. Thank you for the consideration!

@saucepoint saucepoint closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants