update implementations

Uniswap · Jun 26, 2024 · eaabe37 · eaabe37
1 parent 532f60c
commit eaabe37
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/contracts/middleware/BaseMiddleware.sol b/contracts/middleware/BaseMiddleware.sol
@@ -26,6 +26,7 @@ contract BaseMiddleware is Proxy {
     }
 
     // yo how do i remove this warning
-    // receive() external payable {
-    // }
+    receive() external payable {
+        _delegate(_implementation());
+    }
 }
diff --git a/test/shared/implementation/BaseMiddlewareImplementation.sol b/test/shared/implementation/BaseMiddlewareImplementation.sol
@@ -11,9 +11,6 @@ contract BaseMiddlewareImplementation is BaseMiddleware {
     constructor(IPoolManager _poolManager, address _implementation, BaseMiddleware addressToEtch)
         BaseMiddleware(_poolManager, _implementation)
     {
-        //Hooks.validateHookPermissions(addressToEtch, getHookPermissions());
+        Hooks.validateHookPermissions(IHooks(address(addressToEtch)), BaseHook(_implementation).getHookPermissions());
     }
-
-    // make this a no-op in testing
-    //function validateHookAddress(BaseHook _this) internal pure override {}
 }
diff --git a/test/shared/implementation/FeeTakingLiteImplementation.sol b/test/shared/implementation/FeeTakingLiteImplementation.sol
@@ -5,12 +5,8 @@ import {BaseHook} from "../../../contracts/BaseHook.sol";
 import {FeeTakingLite} from "../../middleware/FeeTakingLite.sol";
 import {IPoolManager} from "@uniswap/v4-core/src/interfaces/IPoolManager.sol";
 import {Hooks} from "@uniswap/v4-core/src/libraries/Hooks.sol";
+import {IHooks} from "@uniswap/v4-core/src/interfaces/IHooks.sol";
 
 contract FeeTakingLiteImplementation is FeeTakingLite {
-    constructor(IPoolManager _poolManager, FeeTakingLite addressToEtch) FeeTakingLite(_poolManager) {
-        //Hooks.validateHookPermissions(addressToEtch, getHookPermissions());
-    }
-
-    // make this a no-op in testing
-    //function validateHookAddress(BaseHook _this) internal pure override {}
+    constructor(IPoolManager _poolManager, FeeTakingLite addressToEtch) FeeTakingLite(_poolManager) {}
 }