add mint position event (#279)

* add mint position event * merge main
Uniswap · Aug 5, 2024 · af688af · af688af
1 parent cf4e2ad
commit af688af
Show file tree

Hide file tree

Showing 14 changed files with 24 additions and 11 deletions.
diff --git a/.forge-snapshots/PositionManager_mint_native.snap b/.forge-snapshots/PositionManager_mint_native.snap
@@ -1 +1 @@
-336966
+340631
diff --git a/.forge-snapshots/PositionManager_mint_nativeWithSweep_withClose.snap b/.forge-snapshots/PositionManager_mint_nativeWithSweep_withClose.snap
@@ -1 +1 @@
-345458
+349123
diff --git a/.forge-snapshots/PositionManager_mint_nativeWithSweep_withSettlePair.snap b/.forge-snapshots/PositionManager_mint_nativeWithSweep_withSettlePair.snap
@@ -1 +1 @@
-344760
+348425
diff --git a/.forge-snapshots/PositionManager_mint_onSameTickLower.snap b/.forge-snapshots/PositionManager_mint_onSameTickLower.snap
@@ -1 +1 @@
-314948
+318613
diff --git a/.forge-snapshots/PositionManager_mint_onSameTickUpper.snap b/.forge-snapshots/PositionManager_mint_onSameTickUpper.snap
@@ -1 +1 @@
-315590
+319255
diff --git a/.forge-snapshots/PositionManager_mint_sameRange.snap b/.forge-snapshots/PositionManager_mint_sameRange.snap
@@ -1 +1 @@
-241172
+244837
diff --git a/.forge-snapshots/PositionManager_mint_settleWithBalance_sweep.snap b/.forge-snapshots/PositionManager_mint_settleWithBalance_sweep.snap
@@ -1 +1 @@
-370990
+374655
diff --git a/.forge-snapshots/PositionManager_mint_warmedPool_differentRange.snap b/.forge-snapshots/PositionManager_mint_warmedPool_differentRange.snap
@@ -1 +1 @@
-320966
+324631
diff --git a/.forge-snapshots/PositionManager_mint_withClose.snap b/.forge-snapshots/PositionManager_mint_withClose.snap
@@ -1 +1 @@
-372266
+375931
diff --git a/.forge-snapshots/PositionManager_mint_withSettlePair.snap b/.forge-snapshots/PositionManager_mint_withSettlePair.snap
@@ -1 +1 @@
-371406
+375071
diff --git a/.forge-snapshots/PositionManager_multicall_initialize_mint.snap b/.forge-snapshots/PositionManager_multicall_initialize_mint.snap
@@ -1 +1 @@
-416740
+420405
diff --git a/src/PositionManager.sol b/src/PositionManager.sol
@@ -255,6 +255,8 @@ contract PositionManager is
         BalanceDelta liquidityDelta = _modifyLiquidity(config, liquidity.toInt256(), bytes32(tokenId), hookData);
         liquidityDelta.validateMaxIn(amount0Max, amount1Max);
         positionConfigs.setConfigId(tokenId, config);
+
+        emit MintPosition(tokenId, config);
     }
 
     /// @dev this is overloaded with ERC721Permit_v4._burn

diff --git a/src/interfaces/IPositionManager.sol b/src/interfaces/IPositionManager.sol
@@ -12,6 +12,8 @@ interface IPositionManager is INotifier {
     error DeadlinePassed();
     error IncorrectPositionConfigForTokenId(uint256 tokenId);
 
+    event MintPosition(uint256 indexed tokenId, PositionConfig config);
+
     /// @notice Unlocks Uniswap v4 PoolManager and batches actions for modifying liquidity
     /// @dev This is the standard entrypoint for the PositionManager
     /// @param payload is an encoding of actions, and parameters for those actions

diff --git a/test/position-managers/PositionManager.t.sol b/test/position-managers/PositionManager.t.sol
@@ -935,5 +935,14 @@ contract PositionManagerTest is Test, PosmTestSetup, LiquidityFuzzers {
         assertLt(uint256(int256(deltaDecrease.amount1())), uint256(int256(-deltaMint.amount1()))); // amount1 in the second position was greater than amount1 in the first position
     }
 
+    function test_mint_emits_event() public {
+        PositionConfig memory config = PositionConfig({poolKey: key, tickLower: -60, tickUpper: 60});
+        uint256 tokenId = lpm.nextTokenId();
+
+        vm.expectEmit(true, false, false, true, address(lpm));
+        emit IPositionManager.MintPosition(tokenId, config);
+        mint(config, 1e18, ActionConstants.MSG_SENDER, ZERO_BYTES);
+    }
+
     function test_mint_slippageRevert() public {}
 }