Skip to content

Commit

Permalink
remove rand comments
Browse files Browse the repository at this point in the history
  • Loading branch information
snreynolds committed Jun 20, 2024
1 parent f8b2f6e commit 9edb230
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
7 changes: 2 additions & 5 deletions contracts/interfaces/INonfungiblePositionManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,10 @@ import {LiquidityRange} from "../types/LiquidityRange.sol";

interface INonfungiblePositionManager {
struct TokenPosition {
address owner; // 160
LiquidityRange range; // 576
address owner;
LiquidityRange range;
}

// using 736 - 3 SLOTS
// total 768 - 32 bits free space

// NOTE: more gas efficient as LiquidityAmounts is used offchain
function mint(
LiquidityRange calldata position,
Expand Down
7 changes: 1 addition & 6 deletions contracts/types/LiquidityRange.sol
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,11 @@ pragma solidity ^0.8.24;
import {PoolKey} from "@uniswap/v4-core/src/types/PoolKey.sol";

struct LiquidityRange {
PoolKey poolKey; // 528
PoolKey poolKey;
int24 tickLower;
int24 tickUpper;
}

// can we force integrators to instead pass in the liquidity range? and we only store a hash?

// 2 256 = 512
// 576

type LiquidityRangeId is bytes32;

/// @notice Library for computing the ID of a liquidity range
Expand Down

0 comments on commit 9edb230

Please sign in to comment.