chore: adherence to CEI in unsubscribe (#303)

Uniswap · Aug 27, 2024 · 870b46c · 870b46c
1 parent d325f82
commit 870b46c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/base/Notifier.sol b/src/base/Notifier.sol
@@ -69,11 +69,11 @@ abstract contract Notifier is INotifier {
         _positionConfigs(tokenId).setUnsubscribe();
         ISubscriber _subscriber = subscriber[tokenId];
 
-        uint256 subscriberGasLimit = block.gaslimit.calculatePortion(BLOCK_LIMIT_BPS);
+        delete subscriber[tokenId];
 
+        uint256 subscriberGasLimit = block.gaslimit.calculatePortion(BLOCK_LIMIT_BPS);
         try _subscriber.notifyUnsubscribe{gas: subscriberGasLimit}(tokenId, config, data) {} catch {}
 
-        delete subscriber[tokenId];
         emit Unsubscribed(tokenId, address(_subscriber));
     }