custom reverts

Uniswap · Aug 30, 2024 · 845a1d4 · 845a1d4
1 parent dd948d2
commit 845a1d4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/base/Notifier.sol b/src/base/Notifier.sol
@@ -46,7 +46,7 @@ abstract contract Notifier is INotifier {
         _positionConfigs(tokenId).setSubscribe();
         ISubscriber _subscriber = subscriber[tokenId];
 
-        if (_subscriber != NO_SUBSCRIBER) revert AlreadySubscribed(address(_subscriber));
+        if (_subscriber != NO_SUBSCRIBER) AlreadySubscribed.selector.revertWith(address(_subscriber));
         subscriber[tokenId] = ISubscriber(newSubscriber);
 
         bool success =
@@ -68,7 +68,7 @@ abstract contract Notifier is INotifier {
     {
         _positionConfigs(tokenId).setUnsubscribe();
         ISubscriber _subscriber = subscriber[tokenId];
-        if (_subscriber == NO_SUBSCRIBER) revert NotSubscribed();
+        if (_subscriber == NO_SUBSCRIBER) NotSubscribed.selector.revertWith();
 
         delete subscriber[tokenId];
 
@@ -110,7 +110,7 @@ abstract contract Notifier is INotifier {
     }
 
     function _call(address target, bytes memory encodedCall) internal returns (bool success) {
-        if (target.code.length == 0) revert NoCodeSubscriber();
+        if (target.code.length == 0) NoCodeSubscriber.selector.revertWith();
         assembly ("memory-safe") {
             success := call(gas(), target, 0, add(encodedCall, 0x20), mload(encodedCall), 0, 0)
         }

diff --git a/test/position-managers/PositionManager.notifier.t.sol b/test/position-managers/PositionManager.notifier.t.sol
@@ -100,7 +100,7 @@ contract PositionManagerNotifierTest is Test, PosmTestSetup, GasSnapshot {
     /// @notice Revert when subscribing to an address without code
     function test_subscribe_revert_empty(address _subscriber) public {
         vm.assume(_subscriber.code.length == 0);
-        
+
         uint256 tokenId = lpm.nextTokenId();
         mint(config, 100e18, alice, ZERO_BYTES);