Skip to content

Commit

Permalink
fix: remove unused v4Owner variable
Browse files Browse the repository at this point in the history
  • Loading branch information
marktoda committed Nov 6, 2024
1 parent f788998 commit 8055ecb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
4 changes: 0 additions & 4 deletions src/UniswapV4DeployerCompetition.sol
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ contract UniswapV4DeployerCompetition is IUniswapV4DeployerCompetition {
/// @dev The submitter of the best address found so far
address public bestAddressSubmitter;

/// @dev The owner of the v4 contract
address public immutable v4Owner;
/// @dev The deadline for the competition
uint256 public immutable competitionDeadline;
/// @dev The init code hash of the V4 contract
Expand All @@ -32,13 +30,11 @@ contract UniswapV4DeployerCompetition is IUniswapV4DeployerCompetition {

constructor(
bytes32 _initCodeHash,
address _v4Owner,
uint256 _competitionDeadline,
address _exclusiveDeployer,
uint256 _exclusiveDeployLength
) {
initCodeHash = _initCodeHash;
v4Owner = _v4Owner;
competitionDeadline = _competitionDeadline;
exclusiveDeployDeadline = _competitionDeadline + _exclusiveDeployLength;
deployer = _exclusiveDeployer;
Expand Down
6 changes: 2 additions & 4 deletions test/UniswapV4DeployerCompetition.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,8 @@ contract UniswapV4DeployerCompetitionTest is Test {
deployer = makeAddr("Deployer");
vm.prank(deployer);
initCodeHash = keccak256(abi.encodePacked(type(PoolManager).creationCode, uint256(uint160(v4Owner))));
competition = new UniswapV4DeployerCompetition(
initCodeHash, v4Owner, competitionDeadline, deployer, exclusiveDeployLength
);
assertEq(competition.v4Owner(), v4Owner);
competition =
new UniswapV4DeployerCompetition(initCodeHash, competitionDeadline, deployer, exclusiveDeployLength);
}

function test_updateBestAddress_succeeds(bytes32 salt) public {
Expand Down

0 comments on commit 8055ecb

Please sign in to comment.