feedback: memory hookData

Uniswap · Jun 17, 2024 · 1cb1948 · 1cb1948
1 parent 240c8e1
commit 1cb1948
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/.forge-snapshots/decreaseLiquidity_erc20.snap b/.forge-snapshots/decreaseLiquidity_erc20.snap
@@ -1 +1 @@
-187220
+187367
diff --git a/.forge-snapshots/decreaseLiquidity_erc6909.snap b/.forge-snapshots/decreaseLiquidity_erc6909.snap
@@ -1 +1 @@
-166214
+166360
diff --git a/.forge-snapshots/increaseLiquidity_erc20.snap b/.forge-snapshots/increaseLiquidity_erc20.snap
@@ -1 +1 @@
-187943
+188126
diff --git a/.forge-snapshots/increaseLiquidity_erc6909.snap b/.forge-snapshots/increaseLiquidity_erc6909.snap
@@ -1 +1 @@
-163546
+163729
diff --git a/.forge-snapshots/mintWithLiquidity.snap b/.forge-snapshots/mintWithLiquidity.snap
@@ -1 +1 @@
-485501
+485679
diff --git a/contracts/base/BaseLiquidityManagement.sol b/contracts/base/BaseLiquidityManagement.sol
@@ -51,11 +51,11 @@ contract BaseLiquidityManagement is SafeCallback {
 
     mapping(address owner => mapping(LiquidityRangeId rangeId => Position)) public positions;
 
-    error LockFailure();
+    error UnlockFailure();
 
     constructor(IPoolManager _poolManager) ImmutableState(_poolManager) {}
 
-    function modifyLiquidity(LiquidityRange memory range, int256 liquidityDelta, bytes calldata hookData, bool claims)
+    function modifyLiquidity(LiquidityRange memory range, int256 liquidityDelta, bytes memory hookData, bool claims)
         internal
         returns (BalanceDelta delta)
     {
@@ -70,7 +70,7 @@ contract BaseLiquidityManagement is SafeCallback {
     function _unlockCallback(bytes calldata data) internal override returns (bytes memory) {
         (bool success, bytes memory returnData) = address(this).call(data);
         if (success) return returnData;
-        if (returnData.length == 0) revert LockFailure();
+        if (returnData.length == 0) revert UnlockFailure();
         // if the call failed, bubble up the reason
         /// @solidity memory-safe-assembly
         assembly {