tests: Make and use a common SWAP_PARAMS in Deployers.sol #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prosperring
force-pushed
the
test-suite-improvements
branch
from
6719e56 to
918aa0e
Compare
hensha256
reviewed
May 20, 2024
| 24984 |
There was a problem hiding this comment.
please can you run tests with forge test --isolate not forge test and push the snapshots
prosperring
force-pushed
the
test-suite-improvements
branch
from
918aa0e to
6580bad
Compare
hensha256
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves Issue #390
Related Issue
Which issue does this pull request resolve?
Partially #390
Description of changes
Add
SWAP_PARAMStoDeployers.soland deprecate repeatedIPoolManager.SwapParams({zeroForOne: true, amountSpecified: -100, sqrtPriceLimitX96: SQRT_RATIO_1_2})